Re: [libvirt-designer 2/3] Accept 'iso' format in gvir_designer_domain_add_disk_full()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 02, 2013 at 11:12:29AM +0100, Daniel P. Berrange wrote:
> I don't think it is a good idea to overload 'format' for this purpose.
> It is perfectly acceptable to back a CDROM device by a qcow2 files.
> I think we should just have a gvir_designer_domain_add_cdrom() method
> or some other indicator

Now that you point it out, I totally agree. I've went with
add_cdrom_file, add_cdrom_device, add_floppy_file, add_floppy_device and
sent a v2, though this scheme won't really scale well( it's already missing
"lun").

Christophe

Attachment: pgpNQXwT5ICyL.pgp
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]