On Wed, Apr 03, 2013 at 11:38:01AM +0200, Christophe Fergeau wrote:
> ---
> libvirt-designer/libvirt-designer-domain.c | 120 +++++++++++++++++++++++++++++
> 1 file changed, 120 insertions(+)
>
> diff --git a/libvirt-designer/libvirt-designer-domain.c b/libvirt-designer/libvirt-designer-domain.c
> index c0b0e19..7b1cb33 100644
> --- a/libvirt-designer/libvirt-designer-domain.c
> +++ b/libvirt-designer/libvirt-designer-domain.c
> @@ -58,6 +58,8 @@ typedef enum {
> /* add new type here */
> } GVirDesignerDomainNICType;
>
> +static void gvir_designer_domain_add_sound(GVirDesignerDomain *design);
> +
> static GQuark
> gvir_designer_domain_error_quark(void)
> {
> @@ -389,6 +391,7 @@ static void gvir_designer_domain_add_console(GVirDesignerDomain *design)
> g_object_unref(G_OBJECT(console));
> }
>
> +
> static void gvir_designer_domain_add_input(GVirDesignerDomain *design)
> {
> GVirConfigDomainInput *input;
> @@ -765,6 +768,7 @@ gvir_designer_domain_setup_guest(GVirDesignerDomain *design,
> gvir_designer_domain_set_lifecycle(design);
> gvir_designer_domain_add_console(design);
> gvir_designer_domain_add_input(design);
> + gvir_designer_domain_add_sound(design);
IMHO we should not be adding sound by default, since it is not the kind
of device any server is going to want - it is only relevant to desktop
installs. Thus it should be opt-in.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list