On Mon, Apr 01, 2013 at 04:57:00PM -0600, Eric Blake wrote: > Reported by Anthony Messina in > https://bugzilla.redhat.com/show_bug.cgi?id=904692 > Present since introduction of smartcard support in commit f5fd9baa > > * src/qemu/qemu_command.c (qemuBuildCommandLine): Match qemu spelling. > --- > > No one has spotted my bug, latent since Feb 2011, until now. I > guess smartcard use is not very common... > > src/qemu/qemu_command.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c > index a0c278f..59a6061 100644 > --- a/src/qemu/qemu_command.c > +++ b/src/qemu/qemu_command.c > @@ -6843,7 +6843,7 @@ qemuBuildCommandLine(virConnectPtr conn, > } else { > database = VIR_DOMAIN_SMARTCARD_DEFAULT_DATABASE; > } > - virBufferAsprintf(&opt, ",database=%s", database); > + virBufferAsprintf(&opt, ",db=%s", database); > break; > > case VIR_DOMAIN_SMARTCARD_TYPE_PASSTHROUGH: ACK, Is a test case worthwhile ? It wouldn't have spotted this if the test case had had the same typo though Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list