[PATCH 1/3] libvirt: Increase connection reference count for callbacks

[Viktor Mihajlovski <mihajlov@xxxxxxxxxxxxxxxxxx>]

By adjusting the reference count of the connection object we
prevent races between callback function and virConnectClose.

Signed-off-by: Viktor Mihajlovski <mihajlov@xxxxxxxxxxxxxxxxxx>
---
 src/libvirt.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/libvirt.c b/src/libvirt.c
index 02d5dd9..f7df26a 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -20184,6 +20184,8 @@ int virConnectRegisterCloseCallback(virConnectPtr conn,
         return -1;
     }
 
+    virObjectRef(conn);
+
     virMutexLock(&conn->lock);
 
     virCheckNonNullArgGoto(cb, error);
@@ -20204,6 +20206,7 @@ int virConnectRegisterCloseCallback(virConnectPtr conn,
 
 error:
     virMutexUnlock(&conn->lock);
+    virObjectUnref(conn);
     virDispatchError(NULL);
     return -1;
 }
@@ -20253,6 +20256,8 @@ int virConnectUnregisterCloseCallback(virConnectPtr conn,
 
     virMutexUnlock(&conn->lock);
 
+    virObjectUnref(conn);
+
     return 0;
 
 error:
-- 
1.7.9.5

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list