On Mon, Feb 25, 2013 at 06:44:32PM +0100, Paolo Bonzini wrote: > A better way to do this would be to use a configuration file like > > [iscsi "target-name"] > user = name > password = pwd > > and pass it via -readconfig. This would remove the username and password > from the "ps" output. For now, however, keep this solution. Urgh, we only accepted this for RBD on the condition that they were working on adding a monitor command to set secrets securely. Did that never happen ? /me wishes we'd never added code to allow it to be passed the CLI. > Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx> > --- > src/qemu/qemu_command.c | 80 ++++++++++++++++++---- > ...qemuxml2argv-disk-drive-network-iscsi-auth.args | 1 + > tests/qemuxml2argvtest.c | 2 + > 3 files changed, 70 insertions(+), 13 deletions(-) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-iscsi-auth.args Very reluctant ACK on the basis that its is no worse than the mess we already have for rbd :-( Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list