On 03/14/2013 01:09 PM, Laine Stump wrote: >>>> - capng_clear(CAPNG_SELECT_BOTH); >>>> + if (clearExistingCaps || (uid != 1 && uid != 0)) >>> Did you mean uid != 0? >> Well, actually I meant "uid != -1 && uid != 0" (and I had to look at it >> 5 times to see that the negative sign was missing). 'uid != -1' isn't portable; it has to be 'uid != (uid_t)-1'. >>> ACK with those problems addressed. >>> > > Okay, I pushed it after adding "!!" to the bool arg and fixing the "1" > to "-1". I also pushed the patch to the v1.0.3-maint branch. Guess we'll need to post the trivial followup patches to both places as well, then. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list