On 03/14/2013 11:52 AM, Viktor Mihajlovski wrote: > On 03/14/2013 06:29 PM, Daniel P. Berrange wrote: >> >> Sorry, I think I should have been clearer before. I was only meaning to >> reject the rename of the string. Renaming the exist enum symbol is fine, >> as long as corresponding string is left unchanged. So no need for this >> new enum entry. >> >> >> Daniel >> > > I understood that this was technically feasible, however found it > strange to use "virtio-scsi-pci" in a, say CCW context. > If you think that this is only a minor quirk we can go that way. > Just let me know ... it's only a stroke of the pen :-). You can do s/QEMU_CAPS_VIRTIO_SCSI_PCI/QEMU_CAPS_VIRTIO_SCSI/ so that the bulk of the code looks sane. The only thing you can't do is rename s/"virtio-scsi-pci"/"virtio-scsi"/, because that has impacts to XML which is preserved over libvirtd restarts. But you CAN do: s|"virtio-scsi-pci";|& /* the -pci suffix is a back-compat historical wart */| and then you don't need a new cap bit. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list