On Mon, Mar 11, 2013 at 04:06:15PM +0100, Peter Krempa wrote:
> ---
> src/Makefile.am | 1 +
> src/lxc/lxc_conf.c | 8 ++++++++
> src/lxc/lxc_conf.h | 2 ++
> src/lxc/lxc_controller.c | 7 ++++++-
> src/lxc/lxc_domain.c | 13 ++++++-------
> src/lxc/lxc_domain.h | 2 +-
> src/lxc/lxc_driver.c | 43 ++++++++++++++++++++++++-------------------
> src/lxc/lxc_process.c | 9 +++++----
> 8 files changed, 53 insertions(+), 32 deletions(-)
ACK
> diff --git a/src/lxc/lxc_domain.h b/src/lxc/lxc_domain.h
> index 882f34a..007ea84 100644
> --- a/src/lxc/lxc_domain.h
> +++ b/src/lxc/lxc_domain.h
> @@ -38,6 +38,6 @@ struct _virLXCDomainObjPrivate {
> pid_t initpid;
> };
>
> -void virLXCDomainSetPrivateDataHooks(virCapsPtr caps);
> +extern virDomainXMLPrivateDataCallbacks virLXCDriverPrivateDataCallbacks;
Do we need a policy on use of 'extern' ? Almost none of our header files
use it, so I think we should just delete it from those few which do and
forbid it.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list