On Thu, Mar 07, 2013 at 08:57:52PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" <mst@xxxxxxxxxx> writes: > > > libvirt has a long-standing bug: when removing the device, > > it can request removal but does not know when the > > removal completes. Add an event so we can fix this in a robust way. > > > > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx> > > Speaking as the acting QMP maintainer, just to avoid misunderstandings: > there's disagreement on the event's design, namely when it should fire, > and how it should name the device. I don't want the discussion > preempted by a commit. Yes, you are asking for more functionality, but can I add this in a follow-up commit please? I prefer this patch as is, as it can be backported to stable branches and downstreams. Upstream a follow up patch can add fields and more triggers which won't apply to any downstreams. This patch will help resolve a set of serious long-standing bugs, see e.g. https://bugzilla.redhat.com/show_bug.cgi?id=813748 -- MST -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list