On 03/04/2013 04:31 PM, Anthony Liguori wrote: > Eric Blake <eblake@xxxxxxxxxx> writes: > >> There is some controversy[1] on the qemu list on whether qemu should >> have ever allowed arbitrary file name passthrough, or whether it >> should be restricted to JUST /dev/random and /dev/hwrng. It is >> always easier to add support for additional filenames than it is >> to remove support for something once released, so this patch >> restricts libvirt 1.0.3 (where the virtio-random backend was first >> supported) to just the two uncontroversial names, letting us defer >> to a later date any decision on whether supporting arbitrary files >> makes sense. Additionally, since qemu 1.4 does NOT support >> /dev/fdset/nnn fd passthrough for the backend, limiting to just >> two known names means that we don't get tempted to try fd >> passthrough where it won't work. > > Acked-by: Anthony Liguori <aliguori@xxxxxxxxxx> > Thanks; I've pushed this into libvirt. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list