Re: [PATCH 01/10] conf: DHCP - add state for DHCP Relay and On/Off switch

[Laine Stump <laine@xxxxxxxxx>]

On 02/27/2013 09:18 PM, TJ wrote:

Signed-off-by: TJ <linux@xxxxxx>
---
 src/conf/network_conf.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/conf/network_conf.h b/src/conf/network_conf.h
index c509915..8400eab 100644
--- a/src/conf/network_conf.h
+++ b/src/conf/network_conf.h
@@ -144,6 +144,10 @@ struct _virNetworkIpDef {
     char *bootfile;
     virSocketAddr bootserver;
 +    /* when false no DHCP server is started */
+    bool dhcp_enabled;
+    /* when true ranges are ignored and a DHCP relay-agent started */
+    bool dhcp_relay;

I think Eric mentioned elsewhere that your patches are *extremely* small. At least both the data structure, parser, and formatter changes should go into a single patch. For that matter, this functionality is small enough that you could put the struct change, parser change, implementation of the feature in bridge_driver, makefile and configure changes, AND the documentation addition into a single patch.

    };
  typedef struct _virNetworkForwardIfDef virNetworkForwardIfDef;
@@ -234,6 +238,7 @@ typedef virNetworkObj *virNetworkObjPtr;
 struct _virNetworkObj {
     virMutex lock;
 +    pid_t dhcprelayPid;
     pid_t dnsmasqPid;
     pid_t radvdPid;
     unsigned int active : 1;

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list