On 02/27/2013 08:49 PM, Eric Blake wrote: >>> Your commit message is missing some substance, such as a summary of what >>> is being added. >> >> The first line of the commit message is in the email subject, and describes the commit. >> >> "conf: DHCP - add state for DHCP Relay and On/Off switch" > > The summary is nice, but we also want to see a sample of the XML that > you are adding. See, for example, commit 1716e7a6. The summary in 6/10 is more what I was looking for; maybe it's worth squashing that commit and this one into a single patch? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list