On 02/22/2013 09:58 AM, Philipp Hahn wrote: > @Guido: for Debian only the 4th patch is relevant, which applies with some > re-indention. Unfortunately, the 4th patch is the one that needs rework. > > Additional issues: > - UID and GID 4294967295 happens to be the same as -1, so hopefully nobody > uses it. Should this be documented somewhere? Unless someone ever invents a system with 64-bit uid_t (to date, no one has - your claims about u64 to the contrary), treating 4294967295 as (uid_t)-1 is safe. POSIX already guaranteed that (uid_t)-1 cannot be used as a valid user id. > - Some regression test? Did you run 'make check' on your patch? We already have XML output that is affected by the change in output format, and can write the test so that we prove that multiple ways of formatting input all get canonicalized to the same output. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list