On 02/25/2013 10:25 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" <berrange@xxxxxxxxxx> > > This change tried to fix a crash with changing CDROM media but > failed to actually do so > > commit d0172d2b1b5d865aaa042070d7c2d00effb2ff8c > Author: Osier Yang <jyang@xxxxxxxxxx> > Date: Tue Feb 19 20:27:45 2013 +0800 > > qemu: Remove the shared disk entry if the operation is ejecting or updating > > It was still accessing disk->src, when the entire 'disk' object > has been free'd already. Even if it weren't free'd, accessing > the 'src' value of virDomainDiskDef is not allowed without > first validating disk->type is file or block. Just remove the > broken code entirely. > > Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx> > --- > src/qemu/qemu_driver.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list