On Tue, Feb 19, 2013 at 14:22:15 +0000, Daniel P. Berrange wrote:
> On Mon, Feb 18, 2013 at 03:49:24PM +0100, Jiri Denemark wrote:
> > The function does not report any errors so there should be no need too
> > reset an existing error first. Moreover, virTypedParamsFree is mostly
> > called in cleanup phase where it has the potential to reset any useful
> > reported earlier.
> > ---
> > src/util/virtypedparam.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/src/util/virtypedparam.c b/src/util/virtypedparam.c
> > index ae2855a..c196321 100644
> > --- a/src/util/virtypedparam.c
> > +++ b/src/util/virtypedparam.c
> > @@ -1026,7 +1026,6 @@ void
> > virTypedParamsFree(virTypedParameterPtr params,
> > int nparams)
> > {
> > - virResetLastError();
> > virTypedParamsClear(params, nparams);
> > VIR_FREE(params);
> > }
>
> ACK
Thanks, pushed.
Jirka
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list