On 02/19/2013 05:26 AM, Michal Privoznik wrote: > On 19.02.2013 03:14, John Ferlan wrote: >> > > ACK to the 2-8 patches. The first one needs a bit discussion IMO. > > Michal > Thanks - I'll fix the whitespace in 8/8 too - I remember looking a few other examples using gitk and saw that the only changes were whitespace removal. I'll work on the changes that have been discussed and resubmit 1/8... Of course I'm still plowing through the plethora of mail generated on this list over the last 2 days. I agree that the style in there was a bit dated, but I went with the try to follow the existing style model rather than rewrite the world model. w/r/t: the API documentation - I just cut-n-paste'd comments/code - I thought to look up the documentation when I saw the comment, but probably got distracted by the time it came to actually look it up. As for using newer interfaces over older ones - that's fine too, I was merely going for different ways to extract the data. I agree that it's probably best to go with the newer ones. I did wonder while making the changes - does it make sense to "install" the example somewhere? I see a bunch of examples in my '/usr/share/doc/*/examples' directories. Not that I'd know how to do this mind you, but I supposed I'd have to be willing to learn now wouldn't I? John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list