On 02/13/2013 05:59 AM, Peter Krempa wrote: > Adds XML parsing and qemu commandline tests for the VirtIO RNG device > support. > --- > .../qemuxml2argv-virtio-rng-egd.args | 1 + > .../qemuxml2argv-virtio-rng-egd.xml | 26 ++++++++++++++++++++++ > .../qemuxml2argv-virtio-rng-random.args | 1 + > .../qemuxml2argv-virtio-rng-random.xml | 23 +++++++++++++++++++ > tests/qemuxml2argvtest.c | 5 +++++ > tests/qemuxml2xmltest.c | 3 +++ > 6 files changed, 59 insertions(+) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-egd.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-egd.xml > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-random.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-random.xml > ACK - seems OK to me. My only question would be does '/test/phile' have to exist? That is are there any assumptions that '/test' is present? -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list