Re: [PATCH] regex: gnulib guarantees that we have regex support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/11/2013 03:13 PM, Eric Blake wrote:
> No need to use HAVE_REGEX_H - our use of gnulib guarantees that
> the header exists and works, regardless of platform.  Similarly,
> we can unconditionally assume a compiling <sys/wait.h> (although
> the mingw version of this header is not full-featured).
> 
> * src/storage/storage_backend.c: Drop useless conditional.
> * tests/testutils.c: Likewise.
> ---
> 
> I noticed this while trying to clean up a VPATH test failure.

No review, so I went ahead and pushed it under the trivial rule.

> @@ -25,9 +25,7 @@
> 
>  #include <string.h>
>  #include <stdio.h>
> -#if HAVE_REGEX_H
> -# include <regex.h>
> -#endif
> +#include <regex.h>
>  #include <sys/types.h>
>  #include <sys/wait.h>
>  #include <unistd.h>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]