Re: [PATCH 00/11] Revisit xen driver Coverity cleanup changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/08/2013 04:15 PM, Jim Fehlig wrote:
>> I was trying to go with the 80 column rule.  For 99% they could fit on
>> one line if I removed one extra space. For a couple, spanning 2 lines
>> kept the 80 columns in effect. In looking at other drivers - I don't
>> think any of them typecast the *PrivatePtr)<var>->privateData, so I
>> could remove that too. I left them in only because they were there.
>>   
> 
> Yeah, good point. And dropping the cast will make all of them fit within
> 80 columns :).

The cast is needed in C++; but libvirt is C, and void* automatically
casts to whatever type you need without having to be explicit.  Go ahead
and drop the cast.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]