On 02/08/2013 10:27 AM, Daniel P. Berrange wrote: > On Mon, Feb 04, 2013 at 10:45:22AM +0100, Natanael Copa wrote: >> This is a rework of the previous sent 'set public ip for nat' patches [1]. >> >> Changes v2: >> - Use separate attributes for addresses and ports as suggested by Laine. >> - support set port range without setting public ip >> > > Broadly looks good to me. If you get rid of patch 2 which is just > a special case of patch 3, then I'd ack 3 + 4. I didn't want to spend time doing the rebase work myself, so I'll wait for a v2 for patches 3 and 4. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list