On 02/08/2013 03:48 AM, harryxiyou@xxxxxxxxx wrote: > Signed-off-by: Harry Wei <harryxiyou@xxxxxxxxx> > > --- > src/storage/storage_backend_sheepdog.c | 10 ++++++++++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storage_backend_sheepdog.c > index 218284d..1ce5aa4 100644 > --- a/src/storage/storage_backend_sheepdog.c > +++ b/src/storage/storage_backend_sheepdog.c > @@ -120,6 +120,8 @@ virStorageBackendSheepdogRefreshPool(virConnectPtr conn ATTRIBUTE_UNUSED, > virCommandPtr cmd; > > cmd = virCommandNewArgList(COLLIE, "node", "info", "-r", NULL); > + if (cmd == NULL) > + return -1; > virStorageBackendSheepdogAddHostArg(cmd, pool); > virCommandSetOutputBuffer(cmd, &output); > ret = virCommandRun(cmd, NULL); Not needed. If cmd is NULL, virCommandRun will gracefully report the OOM message and return -1. This patch can be dropped. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list