On 02/01/2013 02:57 PM, Stefan Berger wrote: > Add a file descriptor set to the QEMU private domain structure. > > Stefan Berger <stefanb@xxxxxxxxxxxxxxxxxx> > > --- > src/qemu/qemu_domain.c | 9 ++++++++- > src/qemu/qemu_domain.h | 3 +++ > 2 files changed, 11 insertions(+), 1 deletion(-) I think I mentioned this in another thread, and know I mentioned in IRC, but just for archival purposes: This version is overkill; we don't need a bitmap, but can instead just track a per-vm counter that we increment each time we allocate a new fdset (which won't be often enough to worry about overflow). On libvirtd reload, we can recompute the maximum in-use fdset, and set the counter one greater. Qemu won't care if hotunplugging leaves lower-valued fdsets unused, nor if we reuse an fdset across a libvirtd restart that was previously abandoned prior to the libvirtd restart. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list