On Mon, Feb 04, 2013 at 13:51:49 +0000, Daniel P. Berrange wrote: > On Mon, Feb 04, 2013 at 02:51:19PM +0100, Jiri Denemark wrote: > > On Mon, Feb 04, 2013 at 14:01:27 +0100, Jiri Denemark wrote: > > > On Fri, Feb 01, 2013 at 11:18:25 +0000, Daniel P. Berrange wrote: > > > > From: "Daniel P. Berrange" <berrange@xxxxxxxxxx> > > > > > > > > As a step towards making virDomainObjList thread-safe turn it > > > > into an opaque virObject, preventing any direct access to its > > > > internals. > > > > > > > > As part of this a new method virDomainObjListForEach is > > > > introduced to replace all existing usage of virHashForEach > > > ... > > > ACK with the small issues fixed. > > > > Oops, that was premature; make check fails after this patch with a lot > > of errors similar to > > > > error: failed to connect to the hypervisor > > error: Class virDomainObjList must derive from virObjectLockable > > Hmm, I fixed that, but I guess the fix ended up in the wrong patch Oh, right, it seems like the first two hunks of 5/13 fix that and should be moved into this patch. So ACK with the two hunks moved and small issues fixed. Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list