Re: [PATCH 03/17] virsh-pool: Rename helper function buildPoolXML to vshBuildPoolXML

[Osier Yang <jyang@xxxxxxxxxx>]

On 2013年01月22日 02:07, Peter Krempa wrote:
> ---
>   tools/virsh-pool.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c
> index cb9866f..bc400a1 100644
> --- a/tools/virsh-pool.c
> +++ b/tools/virsh-pool.c
> @@ -226,7 +226,7 @@ static const vshCmdOptDef opts_pool_X_as[] = {
>       {.name = NULL}
>   };
>
> -static int buildPoolXML(const vshCmd *cmd, const char **retname, char **xml) {
> +static int vshBuildPoolXML(const vshCmd *cmd, const char **retname, char **xml) {

Deserved to changed the style meanwhile:

static int
vshBuildPoolXML (...)


>       const char *name = NULL, *type = NULL, *srcHost = NULL, *srcPath = NULL,
>                  *srcDev = NULL, *srcName = NULL, *srcFormat = NULL, *target = NULL;
> @@ -303,7 +303,7 @@ cmdPoolCreateAs(vshControl *ctl, const vshCmd *cmd)
>       char *xml;
>       bool printXML = vshCommandOptBool(cmd, "print-xml");
>
> -    if (!buildPoolXML(cmd,&name,&xml))
> +    if (!vshBuildPoolXML(cmd,&name,&xml))
>           return false;
>
>       if (printXML) {
> @@ -387,7 +387,7 @@ cmdPoolDefineAs(vshControl *ctl, const vshCmd *cmd)
>       char *xml;
>       bool printXML = vshCommandOptBool(cmd, "print-xml");
>
> -    if (!buildPoolXML(cmd,&name,&xml))
> +    if (!vshBuildPoolXML(cmd,&name,&xml))
>           return false;
>
>       if (printXML) {

ACK with the style change.

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list