On 01/23/2013 08:28 PM, Osier Yang wrote: > On 2013年01月24日 07:27, Eric Blake wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=876829 complains that >> if a guest is put into S3 state (such as via virsh dompmsuspend) >> and then an external snapshot is taken, qemu forcefully transitions >> the domain to paused, but libvirt doesn't reflect that change >> internally. Thus, a user has to use 'virsh suspend' to get libvirt >> back in sync with qemu state, and if the user doesn't know this >> trick, then the guest appears hung. >> >> * src/qemu/qemu_driver.c (qemuDomainSnapshotCreateActiveExternal): >> Track fact that qemu wakes up a suspended domain on migration. >> --- >> >> /* we need to resume the guest only if it was previously running */ > > As you changed the codes, the comment needs to be changed too. > Fixed... > > ACK with the comment fixed. and pushed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list