Re: [PATCH] selinux: Only create the selabel_handle once.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 23, 2013 at 01:20:48PM -0700, Eric Blake wrote:
> On 01/23/2013 01:12 PM, Richard W.M. Jones wrote:
> > +#if HAVE_SELINUX_LABEL_H
> > +static struct selabel_handle *sehandle = NULL;
> > +static virOnceControl sehandleonce = VIR_ONCE_CONTROL_INITIALIZER;
> 
> Rather than open-coding this, why not use VIR_ONCE_GLOBAL_INIT()?

Because I was copying this from virdbus.c which does it like this.
Perhaps virdbus.c should be fixed?

Version 2 coming up ...

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]