At Sun, 13 Jan 2013 19:09:25 +0100,
Wido den Hollander wrote:
>
> We divert from the one-on-one mapping rule here by not adding the undefineFlags() method
>
> Signed-off-by: Wido den Hollander <wido@xxxxxxxxx>
> ---
> src/main/java/org/libvirt/Domain.java | 24 ++++++++++++++++++++++++
> src/main/java/org/libvirt/jna/Libvirt.java | 1 +
> 2 files changed, 25 insertions(+)
>
> diff --git a/src/main/java/org/libvirt/Domain.java b/src/main/java/org/libvirt/Domain.java
> index 3da6f56..8f4d9da 100644
> --- a/src/main/java/org/libvirt/Domain.java
> +++ b/src/main/java/org/libvirt/Domain.java
> @@ -76,6 +76,17 @@ public class Domain {
> static final int VIR_DOMAIN_XML_UPDATE_CPU = (1 << 2); /* update guest CPU requirements according to host CPU */
> }
>
> + static final class UndefineFlags {
Again, this class and its members should be public.
ACK with this squashed in:
---- >8 ------
diff --git a/src/main/java/org/libvirt/Domain.java b/src/main/java/org/libvirt/Domain.java
index decf6ec..0dcf9f3 100644
--- a/src/main/java/org/libvirt/Domain.java
+++ b/src/main/java/org/libvirt/Domain.java
@@ -83,15 +83,15 @@ public class Domain {
static final int VIR_DOMAIN_XML_UPDATE_CPU = (1 << 2); /* update guest CPU requirements according to host CPU */
}
- static final class UndefineFlags {
+ public static final class UndefineFlags {
/**
* Also remove any managed save
*/
- static final int MANAGED_SAVE = (1 << 0);
+ public static final int MANAGED_SAVE = (1 << 0);
/**
* If last use of domain, then also remove any snapshot metadata
*/
- static final int SNAPSHOTS_METADATA = (1 << 1);
+ public static final int SNAPSHOTS_METADATA = (1 << 1);
}
/**
--
AV-Test GmbH, Henricistraße 20, 04155 Leipzig, Germany
Phone: +49 341 265 310 19
Web:<http://www.av-test.org>
Eingetragen am / Registered at: Amtsgericht Stendal (HRB 114076)
Geschaeftsfuehrer (CEO): Andreas Marx, Guido Habicht, Maik Morgenstern
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list