On 01/22/2013 02:30 PM, Peter Krempa wrote: > This patch adds RNG schemas for adding more information in the topology > output of the NUMA section in the capabilities XML. > > The added elements are designed to provide more information about the > placement and topology of the processors in the system to management > applications. > > The socket_id field represents identification of the physical socket the > CPU is plugged in. This ID may not be identical to the physical socket > ID reported by the kernel. > > The core_id identifies a core within a socket. Also this field may not > accurately represent physical ID's. > > The core_id is guaranteed to be unique within a cell and a socket. There > may be duplicates between sockets. Only cores sharing core_id within one > cell and one socket can be considered as threads. Cores sharing core_id > within sparate cells are distinct cores. > > The siblings field is a list of CPU id's the cpu id's the CPU is sibling > with - thus a thread. The list is in the cpuset format. > --- > docs/schemas/capability.rng | 11 +++++++++++ > 1 file changed, 11 insertions(+) The RNG addition looks fine, but a LOT of this commit message should instead be living somewhere inside docs/formatcaps.html.in file, ideally as part of this same commit. Hmm, that file is already woefully incomplete, as it doesn't even mention how we have <cells> as a subelement of <topology>, so I guess I can live with formal documentation in a followup patch (since it is a bigger job). Weak ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list