> On 17.01.2013 20:35, Alon Levy wrote: > > Adds a qxl-ram attribute globaly to the video.model element, that > > changes > > the resulting qemu command line only if video.type == "qxl". > > > > That attribute gets a default value of 64*1024 only if model.type > > is > > "qxl". In effect not changing any xml or argv for non qxl devices. > > > > For qxl devices a new property is set: > > -global qxl-vga.ram_size=<ram>*1024 > > or > > -global qxl.ram_size=<ram>*1024 > > > > For the main and secondary qxl devices respectively. > > > > The default for the qxl ram bar is the same as the default for the > > qxl > > vram bar, 64*1024. > > --- > > I've added a qxl-ram attribute. There is no precedent for adding am > > attribute > > prefixed like this, so I'm open for any other suggestion on how to > > do it. > > > > docs/schemas/domaincommon.rng | 9 +++- > > src/conf/domain_conf.c | 19 ++++++- > > src/conf/domain_conf.h | 1 + > > src/qemu/qemu_command.c | 58 > > ++++++++++++++++++---- > > .../qemuxml2argv-graphics-spice-compression.args | 2 +- > > .../qemuxml2argv-graphics-spice-compression.xml | 4 +- > > .../qemuxml2argv-graphics-spice-qxl-vga.args | 2 +- > > .../qemuxml2argv-graphics-spice-qxl-vga.xml | 4 +- > > .../qemuxml2argv-graphics-spice.args | 2 +- > > .../qemuxml2argv-graphics-spice.xml | 4 +- > > .../qemuxml2argv-video-device-pciaddr-default.args | 6 +-- > > 11 files changed, 86 insertions(+), 25 deletions(-) > > Just one question - what is the difference between ram_size and > vram_size? If the former is successor of the latter, I think we > should > be using the ram_size and drop vram_size and not pollute XML at all. > However, if there's any difference we should document that. That is, > every XML snippet being introduced must go hand in hand with > extending > docs/format*.html.in. I'll add the docs. Just to be clear, ram_size is distinct from vram_size, both exist at the same time, so it is not a successor. > > Michal > -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list