Re: [PATCH 2/4] openvz: Need to initialize 'ret' for kb_per_pages error path

[Guannan Ren <gren@xxxxxxxxxx>]

On 01/08/2013 11:40 PM, John Ferlan wrote:
> ---
>   src/openvz/openvz_conf.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c
> index 09518d5..1ad3feb 100644
> --- a/src/openvz/openvz_conf.c
> +++ b/src/openvz/openvz_conf.c
> @@ -485,7 +485,7 @@ error:
>   static int
>   openvzReadMemConf(virDomainDefPtr def, int veid)
>   {
> -    int ret;
> +    int ret = -1;
>       char *temp = NULL;
>       unsigned long long barrier, limit;
>       const char *param;

   Is this necessary to do this,  ret will be initialized to a value 
any way
   before any condition clause.

   There is no harm to set it initially.
    ACK

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list