Re: [PATCH 14/28] Convert udev/pciaccess checks to use LIBVIRT_CHECK_PKG

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 11, 2013 at 03:17:01PM -0700, Eric Blake wrote:
> On 01/11/2013 04:05 AM, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
> > 
> > Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
> > ---
> >  configure.ac         | 57 ++++------------------------------------------------
> >  m4/virt-pciaccess.m4 | 26 ++++++++++++++++++++++++
> >  m4/virt-udev.m4      | 32 +++++++++++++++++++++++++++++
> >  3 files changed, 62 insertions(+), 53 deletions(-)
> >  create mode 100644 m4/virt-pciaccess.m4
> >  create mode 100644 m4/virt-udev.m4
> > 
> 
> > +AC_DEFUN([LIBVIRT_RESULT_UDEV],[
> > +  AC_REQUIRE([LIBVIRT_RESULT_PCIACCESS])
> > +  LIBVIRT_RESULT_LIB([UDEV])
> > +])
> 
> Ah, we're starting to get pre-req checks.  You've been sorting by name,
> but this will cause results to be topologically sorted (with leaves
> reverting to sort-by-name).  Works for me.

Yep, this is slightly annoying. I haven't thought of a way to preserve
alphabetical sorting, while allowing topological usage of the macros.
This will get worse once we remove the explicit calls to all these
macros from configure.ac and make the individual hypervisor drivers
call the ones they need

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]