On Fri, Jan 11, 2013 at 11:09:15AM -0700, Eric Blake wrote: > On 01/10/2013 03:20 PM, Eric Blake wrote: > > On 01/10/2013 01:18 PM, Daniel P. Berrange wrote: > >> From: "Daniel P. Berrange" <berrange@xxxxxxxxxx> > >> > >> Most checks for libraries take the same format > >> > >> * --with-libFOO=yes|no|check|/some/path argument > >> * check for a function NNN in libFOO.so > >> * check for a header file DDD/HHH.h > >> * Define a WITH_FOO config.h symbol > >> * Define a WITH_FOO make conditional > >> * Substitute FOO_CFLAGS and FOO_LIBS make variables > >> * Print CFLAGS & LIBS summary at the end > >> > > > > General impression - nice! > > > > >> + m4_expand(cflags_var[=]) > >> + m4_expand(libs_var[=]) > > > > Overkill; you could get by with: > > > > libvirt quality: > > cflags_var= > > libs_var= > > > > Pedantic quality: > > m4_defn([cflags_var])= > > m4_defn([libs_var])= > > Worse, broken on RHEL 5, where autoconf 2.59 lacks m4_expand: > > ./configure: line 90263: syntax error near unexpected token `with_audit=no' > ./configure: line 90263: ` m4_expand(with_audit=no)' Oh, I got rid of all the m4_expand() bits quoted above, but missed some other usages Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list