On Thu, Jan 10, 2013 at 03:20:27PM -0700, Eric Blake wrote: > On 01/10/2013 01:18 PM, Daniel P. Berrange wrote: > > + > > + if test $fail = 1; then > > + AC_MSG_ERROR([You must install the lib]library_name[ library & headers to compile libvirt]) > > It would be really nice if you could run './configure' once and know > _all_ of the libraries to be installed, rather than having to run once > per library because each missing library aborts the script immediately. > I can probably do that as a followup patch, where instead of directly > issuing the error, we instead append the latest error string to a series > of messages, then use a single m4_wrap to do AC_MSG_ERROR at the end of > all collected messages. But that doesn't impact this patch. Hmm, I guess my vision is that in typical usage all the library/pkg tests will always default to 'check', so we'll test them all and report success/failure at the end. If you're actually using --with-sasl=yes, then I'm assuming you've looked at the configure script and decided what you need upfront. > My priority listing of which things to fix (or ignore): > > * spelling errors - must fix before committing > * use m4_tolower instead of m4_translit - please fix before committing > * doc comment for LIBVIRT_RESULT - please fix before committing > * avoid m4_expand - up to you, but it looks simpler if you fix to at > least libvirt quality > * use m4_defn in more places - up to you, and I'll look the other way if > you choose not to fix > > ACK once you cover at least the first bullet, and preferably at least > the first 3 bullets; and of course if your testing of later patches in > the series shows that things still work. I don't need to see a v2 > unless you go for all 5 bullets. Ok, I've made changes 1->4 and pushed Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list