On 01/10/2013 02:14 AM, Jiri Denemark wrote: > On Wed, Jan 09, 2013 at 16:45:11 -0700, Eric Blake wrote: >> The daemon-driver-{qemu,lxc} packages are only built if >> %{with_driver_modules} is specified, so they do not need to >> further test this condition. Likewise, the daemon package >> is only built if %{with_libvirtd} is specified, so it does >> not need to further test this condition. >> >> * libvirt.spec.in (daemon-driver-qemu, daemon-driver-lxc): >> Unconditionally require libvirt-daemon-driver-network. >> (daemon): Unconditionally include lock-driver files. >> --- >> libvirt.spec.in | 6 ------ >> 1 file changed, 6 deletions(-) > > ACK Thanks, pushed. I'm still playing with the idea of a sed script that converts the spec file into a pseudo C file with just #if/#endif lines (spaced so that error messages are still to the right line number), which can then be fed through cppi to enforce the style of patch 2/2, so I'll hold off just a bit on pushing that part. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list