在 2013-01-09三的 10:23 -0500,Cole Robinson写道: > On 01/09/2013 05:31 AM, Daniel P. Berrange wrote: > > On Wed, Jan 09, 2013 at 10:35:33AM +0800, liguang wrote: > >> Signed-off-by: liguang <lig.fnst@xxxxxxxxxxxxxx> > >> --- > >> src/conf/domain_conf.c | 1 + > >> src/conf/domain_conf.h | 1 + > >> src/qemu/qemu_command.c | 4 ++++ > >> 3 files changed, 6 insertions(+), 0 deletions(-) > >> > >> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > >> index 6a7646e..54ba77f 100644 > >> --- a/src/conf/domain_conf.c > >> +++ b/src/conf/domain_conf.c > >> @@ -9548,6 +9548,7 @@ static virDomainDefPtr virDomainDefParseXML(virCapsPtr caps, > >> > >> def->os.bootloader = virXPathString("string(./bootloader)", ctxt); > >> def->os.bootloaderArgs = virXPathString("string(./bootloader_args)", ctxt); > >> + def->os.acpitable = virXPathString("string(./bootloader_args)", ctxt); > >> > > > > This is clearly bogus - you can't just grab an existing XML field and > > repurpose it. Second we shouldn't be requireing the user to specify > > custom ACPI tables just to use the machine type. libvirt should do the > > right thing with q35. > > > > Daniel > > > > Also, there are patches on qemu-devel which claim to remove the -acpitable > requirement. > > https://lists.gnu.org/archive/html/qemu-devel/2013-01/msg00356.html > > - Cole Thanks! -- regards! li guang -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list