On 01/09/2013 02:48 AM, Daniel P. Berrange wrote: >> As it is, with your patch, I just got this failure on RHEL 5: >> >> /usr/bin/perl ./check-symfile.pl l ibvirt.yms \ >> .libs/libvirt.so >> Expected symbol virNetServerClientGetTLSKeySize is not in ELF library >> ... >> >> I still need to do more investigation, but it makes me wonder if we got >> the conditional symfile manipulation correct? > > Yeah, actually I think that's something I forgot to handle. We still need to fix that for when a user explicitly configures --without-gnutls. > on RHEL5, GNUTLS should be present so that symbol ought to have been > built, unless you were testing with --without-gnutls perhaps ? Figured it out: on RHEL 5, automake and autoconf are so old that they don't automatically reconfigure when you use just 'make', so config.h was out of date, and the new HAVE_GNUTLS macro wasn't defined. Forcing a fresh reconfigure fixed the issue to use gnutls in a default build. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list