On 01/02/2013 11:57 PM, Guannan Ren wrote: > QEMU_CAPS_DEVICE_USB_SERIAL /* -device usb-serial */ > --- > src/qemu/qemu_capabilities.c | 2 ++ > src/qemu/qemu_capabilities.h | 1 + > tests/qemuhelptest.c | 21 ++++++++++++++------- > 3 files changed, 17 insertions(+), 7 deletions(-) > ACK. > DO_TEST("qemu-kvm-1.2.0", 1002000, 1, 0, > QEMU_CAPS_VNC_COLON, > QEMU_CAPS_NO_REBOOT, > @@ -1000,7 +1006,8 @@ mymain(void) > QEMU_CAPS_DEVICE_VGA, > QEMU_CAPS_DEVICE_CIRRUS_VGA, > QEMU_CAPS_DEVICE_VMWARE_SVGA, > - QEMU_CAPS_DEVICE_VIDEO_PRIMARY); > + QEMU_CAPS_DEVICE_VIDEO_PRIMARY, > + QEMU_CAPS_DEVICE_USB_SERIAL); > Side question - why are we still parsing -help output of 1.2.0 in our help test, since that should be using QMP instead? And when are we going to improve our testsuite to make sure our QMP capability parsing is doing what we want? But doesn't affect this patch. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list