On 01/03/2013 04:38 PM, Eric Blake wrote: > On 01/03/2013 12:32 PM, Daniel P. Berrange wrote: >> NB, you should restrict the first line of the commit message to >> approx 70 characters. Then have a single blank line, followed >> by the longer description. This ensures that you get sensible >> subject lines :-) > > Also, using the same subject line across multiple patches can cause > grief to backporting efforts. Inserting a prefix to say which portion > of code is touched helps to both remove the ambiguity and make it easier > to see at a glance why there are multiple patches. I've modified the > commit message to: > > parallels: check and handle error for virAsprintf() calls > > Ignore the return in parallelsMakePoolName() since subsequent check > validates name was allocated. I have learned my lesson about the longer lines. A mistake I hope to not make a second time! That certainly was one of those git things I had forgotten I knew, but since it was a few months since I had used git, it wasn't front and center of my consciousness. I was trying to figure out the 'norm' for those prefixes. I wasn't sure if they were automagically placed there, but once I started through the send-email process I realized those are self placed. Something perhaps for the contributing patches web/wiki page for us nubes. > >> ACK > > and I've now pushed 1 and 2, and will continue reading through the > series. Congratulations on your first libvirt patch. > Thanks! -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list