On 12/13/2012 09:09 AM, Jiri Denemark wrote:
> $(srcdir) is already part of $$file since commit f1f9a7ac7e.
> ---
> Pushed as a build-breaker.
>
> src/Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index bb80992..7c2d8ed 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -1451,7 +1451,7 @@ libvirt.syms: libvirt_public.syms $(USED_SYM_FILES) \
> printf 'LIBVIRT_PRIVATE_$(VERSION) {\n\n' >>$@-tmp && \
> printf 'global:\n\n' >>$@-tmp && \
> for file in $(USED_SYM_FILES); do \
> - cat $(srcdir)/$$file >>$@-tmp; \
> + cat $$file >>$@-tmp; \
> done && \
That almost looks like a useless use of cat. Wouldn't it be simpler to:
cat $(USED_SYM_FILES) > $@-tmp
for fewer processes?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list