On Thu, Dec 13, 2012 at 05:46:56AM -0700, Eric Blake wrote: > On 12/13/2012 04:26 AM, Daniel P. Berrange wrote: > > On Tue, Dec 11, 2012 at 08:41:34PM +0000, Daniel P. Berrange wrote: > >> While we're past the freeze date, I'd like to request an > >> exception, for all except the 14th patch. Without the > >> 14th patch, this series has minimal impact on existing code > >> that is used in libvirt so little regression possibility. > >> Further I discovered yesterday that we already have people > >> using this code as custom add-on patches, so I'd like to > >> help them by including it in 1.0.1 > > > > No one has any opinions on this ? > > I think the series has been posted long enough, and even mostly had acks > prior to the freeze, so it's not like a late-breaking code addition, > rather that it has just taken us a while to get it stable. I can agree > with getting it in the tree now, before rc2, as it does improve > reliability of libvirt out-of-the-box on a single machine. Ok, based on your & Michael's ACKs, I'm pushing this (minus the change to make it default). I also validated it didn't break Win32 builds. Hopefully the same is true of BSD/OS-X, but appreciate some testing of that... Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list