Re: [PATCH 2/2] add vnc unix sockets to apparmor policy (v2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Eric Blake (eblake@xxxxxxxxxx):
> On 12/11/2012 01:25 PM, Daniel P. Berrange wrote:
> > On Tue, Dec 11, 2012 at 08:20:30PM +0000, serge@xxxxxxxxxx wrote:
> 
> Instead of putting '(v2)' as a suffix (which I then have to manually
> strip via 'git commit --amend'), it is nicer to put it in the prefix
> [PATCHv2 2/2] (doable with 'git send-email --subject-prefix=PATCHv2',
> and which gets auto-stripped by 'git am').

...

> Likewise, patch changelogs belong best after a --- separator; it's
> useful for the review, but doesn't need to live in git history.

...

Sorry (I actually thought that info was wanted in git history).  Have
noted to make those changes in the future.

> I fixed the commit messages and this alignment,
> 
> > 
> > ACK
> 
> then pushed the series.

Thanks.

-serge

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]