Daniel P. Berrange wrote: > On Sun, Dec 09, 2012 at 09:17:01PM +0400, Roman Bogorodskiy wrote: > > Hello, > > > > Attached an initial version of the patch providing FreeBSD support for > > qemu driver. Initial discussion on the topic started here: > > > > https://www.redhat.com/archives/libvir-list/2012-November/msg00841.html > > > > Roman Bogorodskiy > > The diffstat is > > configure.ac | 18 > src/Makefile.am | 18 > src/cpu/cpu_x86.c | 4 > src/network/bridge_driver.c | 3 > src/network/bsd_bridge_driver.c | 4265 ++++++++++++++++++++++++++++++++++++++++ > src/network/bsd_bridge_driver.h | 67 > src/network/default.xml | 2 > src/nodeinfo.c | 62 > src/qemu/qemu_capabilities.c | 7 > src/qemu/qemu_command.c | 5 > src/qemu/qemu_conf.c | 2 > src/qemu/qemu_driver.c | 10 > src/qemu/qemu_process.c | 14 > src/rpc/virnetsocket.c | 31 > src/util/bsd_virnetdevbridge.c | 522 ++++ > src/util/bsd_virnetdevbridge.h | 54 > src/util/bsd_virnetdevtap.c | 335 +++ > src/util/bsd_virnetdevtap.h | 62 > src/util/processinfo.c | 22 > src/util/virinitctl.c | 2 > src/util/virnetdev.c | 225 ++ > 21 files changed, 5712 insertions(+), 18 deletions(-) > > > As Eric mentioned, I'd really like to see 1 patch per logical > change. This doc I wrote up to help openstack developers contains > useful background info on why it is important: > > http://wiki.openstack.org/GitCommitMessages#Structural_split_of_changes > > ... Hi, Thanks for the valuable comments, I will definitely consider them when breaking the patch into smaller chunks. As for you question on tap devices clean-up: on FreeBSD tap interfaces doesn't get automatically destroyed when they stop being hold by a process, so one would have to destroy them manually. Roman Bogorodskiy
Attachment:
pgpV0QjcTTO9x.pgp
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list