On Fri, Dec 7, 2012 at 1:13 PM, Laine Stump <laine@xxxxxxxxx> wrote: > On 12/07/2012 10:08 AM, Jiri Denemark wrote: >> From: liguang <lig.fnst@xxxxxxxxxxxxxx> >> >> original migration did not aware of offline case, >> so, try to support offline migration quietly >> (did not disturb original migration) by pass >> VIR_MIGRATE_OFFLINE flag to migration APIs if only >> the domain is really inactive, and >> migration process will not puzzled by domain >> offline and exit unexpectedly. >> these changes did not take care of disk images the >> domain required, for them could be transferred by >> other APIs as suggested, then VIR_MIGRATE_OFFLINE >> must not combined with VIR_MIGRATE_NON_SHARED_*. >> and you must do a persistent migration at same time, >> do "virsh migrate --offline --persistent ...". > > > This commit message is *very* confusing. Maybe before pushing you could > rewrite it to make sense to an outsider? > Agreed. If you look at some of my past comments to older version of the patch I rewrote it with a lot more detail. -- Doug Goldstein -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list