On 05.12.2012 17:32, Michal Privoznik wrote: > On 05.12.2012 11:48, Ján Tomko wrote: >> Diff to v1: >> * A flag for virStorageVolCreateXML and virStorageVolCreateXMLFrom >> is used instead of guessing from the allocation element. >> * The flag is exposed and documented in virsh. >> >> Diff to v2: >> * merged first two patches to enable and implement the flag at the same time >> * more documentation >> * fixed spaces to pass syntax-check >> * !! for unsigned -> bool conversion >> * initialize flags in cmdVolCreateFrom and cmdVolClone >> >> Ján Tomko (2): >> storage: allow metadata preallocation when creating qcow2 images >> virsh: allow metadata preallocation when creating volumes >> >> include/libvirt/libvirt.h.in | 4 +++ >> src/libvirt.c | 16 ++++++++++-- >> src/storage/storage_backend.c | 46 ++++++++++++++++++++++++++----------- >> src/storage/storage_backend.h | 3 +- >> src/storage/storage_backend_fs.c | 16 ++++++++----- >> src/storage/storage_driver.c | 6 ++-- >> tools/virsh-volume.c | 25 +++++++++++++++++--- >> tools/virsh.pod | 23 ++++++++++++++++-- >> 8 files changed, 105 insertions(+), 34 deletions(-) >> > > I've ACKed the both patches. However, I am giving time for anybody who > wants to chime in and tell his opinion on 'Since 1.0.1' comment in the > first patch. If nobody replies in near future (say by tomorrow) I'll > push the patches. Possible objection can be pushed as several patch then. > > Michal Pushed now. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list