On Thu, Dec 6, 2012 at 6:59 PM, Eric Blake <eblake@xxxxxxxxxx> wrote: > On 12/05/2012 02:25 AM, Osier Yang wrote: >> Hi, >> >> As a result of RFC [1], this implements the unprivleged SG_IO >> support. Testing is not that enough, but I'd like see the >> reviewing earlier, and meanwhile I'm not going to give up >> the further testing. > > I didn't see where [1] links to. > >> >> Patches 1/10 ~ 4/10 are to introduce the internal list for shared >> disks. >> >> Osier Yang (15): >> qemu: Introduce a list to maintain the shared disks between domains >> qemu: Init/Free the list with the driver's lifecyle >> qemu: Add/remove the shared disk entry during domain's lifecyle >> qemu: Add/Remove the entry of sharedDisks when live >> attaching/detaching > > Are you properly handling backing files as potential shared disks? I > think we really need to reach the point where we can specify the entire > backing chain as part of domain XML, and where we fill in the backing > chain if the user didn't provide it up front. After all, it is entirely > reasonable to allow for: > > base <- A.img > <- B.img > > where A.img is used by domain A, B.img is used by domain B, but where > we'd like to have SG_IO support for both domain's read-only use of base. > I don't know if this will impact what needs to happen in your series. > Not to throw a +1 here but really I have to agree with you. I'd like to see this as it would likely lead to some good cleanup and improvement of functionality regarding backing chains and cross depends. -- Doug Goldstein -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list