On 12/05/2012 12:15 PM, Laine Stump wrote: > This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=767057 > > It was possible to define a network with <forward mode='bridge'> that > had both a bridge device and a forward device defined. These two are > mutually exclusive by definition (if you are using a bridge device, > then this is a host bridge, and if you have a forward dev defined, > this is using macvtap). It was also possible to put <ip>, <dns>, and > <domain> elements in this definition, although those aren't supported > by the current driver (although it's conceivable that some other > driver might support that). > > The items that are invalid by definition, are now checked in the XML > parser (since they will definitely *always* be wrong), and the others > are checked in networkValidate() in the network driver (since, as > mentioned, it's possible that some other network driver, or even this > one, could some day support setting those). > --- > src/conf/network_conf.c | 9 +++++++++ > src/libvirt_private.syms | 1 + > src/network/bridge_driver.c | 29 +++++++++++++++++++++++++++++ > 3 files changed, 39 insertions(+) ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list