On 30.11.2012 21:00, Laine Stump wrote: > On 11/19/2012 11:51 AM, Michal Privoznik wrote: >> Status file keeps track of class_id and floor_sum. It's better >> to keep it updated in case libvirtd is killed. > > I'm not sure why you're doing this type of iterative improvement in > separate patches. Since you would want this functionality in any working > version of the code, and you haven't already pushed the earlier > versions, why not just do it in the original patch that introduces these > functions? > > Likewise, doing part of the functionality, then a bit of infrastructure > to allow the new functionality to work better, and then another patch to > improve the new functionality makes it a bit of a treasure hunt to > review; I like to make my patchsets so that the first patches contain > all the improvements/changes to existing infrastructure that will be > needed, then the following patches introduce the new code, fully > functioning from the beginning. Yeah, these two patches can be joined together. -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list