Re: [PATCH] util: refactor iptables command construction into multiple steps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 22 Nov 2012 15:02:18 +0100
Natanael Copa <ncopa@xxxxxxxxxxxxxxx> wrote:

> Instead of creating an iptables command in one shot, do it in steps
> so we can add conditional options like physdev and protocol.
> 
> This removes code duplication while keeping existing behaviour.
> 
> Signed-off-by: Natanael Copa <ncopa@xxxxxxxxxxxxxxx>
> ---
> 
> This started with me wanting to add support for setting the public ip source
> address when network mode='nat' and there are multiple public ip addresses
> on the external interface.
> 
> On IRC we talked about adding an option in the xml like this:
> <network>
>   <forward mode='nat' publicaddr='n.n.n.n'/>
> </network>
> 
> Which would make iptables use '-j SNAT --to-source n.n.n.n' instead of
> '-j MASQUERADE'.

I have a working patch for the above and it appears to work. I wonder
if we want go for 'publicaddr' as the attribute name?




-nc

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]