Re: [PATCH] virsh: don't crash if shutdown --mode not provided

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 30, 2012 at 02:56:08PM -0700, Eric Blake wrote:
> virStringSplit requires a non-NULL input, but commit cef78ed forgot
> to follow the rule.
> 
> * tools/virsh-domain.c (cmdReboot, cmdShutdown): Avoid NULL deref.
> ---
> 
> Pushing under the build-breaker rule.
> 
>  tools/virsh-domain.c |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)

ACK, thanks for finding this. I guess I forgot to re-run the test
suite after the v2 of my series changing virsh.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]