> > so we'd still need a post-processing path after virStringSplit. > > Well, which users of vshStringToArray actually need that feature ? Commit 9d91a18 merged ,, into vshStringToArray out of a single caller, vshParseSnapshotDiskspec; then commit 2cd4d8e added another caller vshParseSnapshotMemspec. All other callers don't need it. > IIUC, the only ones are those which accept arbitrary user strings, > which is only 1/2 users in virsh. The rest can use the new API > with no practical loss in functionality, since they use fixed strings > where ',' is not used. That works for me. -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list